-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support add + remove blocks to a stack #16
Conversation
The author of this PR, DivadNojnarg, is not an activated member of this organization on Codecov. |
Still todo:
|
@nbenn : I noticed that when I remove a block from a stack with only 1 block, I do get:
which seems consistent. Then for some reasons, the stack seems to automatically add a new block to itself. |
So far: we can add a new block to a stack with a data_block. We can remove that new block and repeat again. What does not work: empty the stack and add a new block: for some reasons the stack refills and this mess up the process. I also don't check when we remove a data block and there are other blocks downstream (this should raise an error in the UI saying that the data block is mandatory)... |
Progress:
@nbenn TO DO: add server testing ( |
I am done with this one @nbenn and @christophsax. Feel free to check. I'll improve the look and feel with the second ongoing pull request. |
Will fix #15